Repository navigation
ASoC: SOF: topology: make the topology parser IPC agnostic - #3287
Merged
plbossart merged 31 commits intoDec 13, 2021
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the topology parser IPC agnostic so that when new IPC versions are introduced, we can reuse the same parser and add
support for the new IPC structures.
The basic idea is that when parsing topology, we parse the tuple array and store them as token/value pairs in the appropriate objects. For example, in the case of the host component, we store it as part of struct snd_sof_widget. Once, the tuple arrays are all parsed, we can build the IPC structs for the respective component whenever needed based on the IPC version in use. In this PR currently, it is done in the topology complete op.
Introduce IPC ops and set the ops based on the IPC version. This PR includes all the required topology related ops for IPC3