Repository navigation
SoundWire: fix pm_runtime usage - #2530
Merged
plbossart merged 8 commits intoNov 5, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bardliao reported a weird behavior in #2521, and suggested a solution in #2526 to make sure resuming a Slave device waits for the bus to be resumed and the enumeration/initialization to complete.
That didn't seem quite right, and after a couple of hours I found major issues leading to timeouts in our solution. Those issues may explain some of the suspend-resume runtime issues we've been seeing randomly for several months now?
There may be other issues hidden, please take the time to look at drivers/soundwire/bus.c and see if you find other problematic cases.