Repository navigation
Asoc: SOF: imx: Add debug support for imx platforms - #2348
Merged
kv2019i merged 1 commit intoAug 25, 2020
Merged
Conversation
IulianOlaru249
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
August 8, 2020 13:09
lyakh
requested changes
Aug 10, 2020
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
just a couple of cosmetic improvements
dbaluta
reviewed
Aug 10, 2020
dbaluta
reviewed
Aug 10, 2020
dbaluta
reviewed
Aug 10, 2020
dbaluta
reviewed
Aug 10, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 10, 2020 08:31
e33e10d to
b309f0f
Compare
IulianOlaru249
changed the title
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 18, 2020 14:22
b309f0f to
f5f550e
Compare
dbaluta
reviewed
Aug 18, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 18, 2020 15:27
f5f550e to
93ed669
Compare
dbaluta
reviewed
Aug 18, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 19, 2020 07:38
93ed669 to
42552cc
Compare
dbaluta
reviewed
Aug 19, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
2 times, most recently
from
August 19, 2020 12:38
51fde80 to
a63324c
Compare
dbaluta
reviewed
Aug 19, 2020
dbaluta
reviewed
Aug 19, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 19, 2020 13:25
a63324c to
03c1988
Compare
dbaluta
reviewed
Aug 19, 2020
kv2019i
requested changes
Aug 19, 2020
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @IulianOlaru249 ! Looks pretty good. A few minor nitpicks.
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 19, 2020 15:48
03c1988 to
107d595
Compare
dbaluta
reviewed
Aug 19, 2020
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 19, 2020 20:15
107d595 to
be06499
Compare
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 20, 2020 07:06
be06499 to
28cab9c
Compare
dbaluta
previously approved these changes
Aug 20, 2020
kv2019i
requested changes
Aug 20, 2020
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @IulianOlaru249 . The empty lines in middle of local variable declarations is still there. This is very, very minor, but better to fix to keep consistency, so please address.
This patch adds debug support for imx platforms. This is important in order to gather information about the state of the DSP in case of an oops and the reason for the oops. This is done by checking if a message with a panic code has been placed in the debug box, in the imx8_dsp_handle_request function from sof/imx. If positive, the function imx8_dump, added in common, will be called. The first step is to gather information about the registers, filename, line number and stack by calling the imx8_get_registers, added in common. Then the information will be printed to the console by calling the get_status function. Signed-off-by: Iulian Olaru <iulianolaru249@yahoo.com>
IulianOlaru249
force-pushed
the
imx_dump_debug
branch
from
August 20, 2020 08:22
28cab9c to
39cdee6
Compare
kv2019i
approved these changes
Aug 21, 2020
lyakh
approved these changes
Aug 24, 2020
dbaluta
approved these changes
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds debug support for imx platforms. This is important in
order to gather information about the state of the DSP in case of an
Oops and the reason for the Oops.
This is done by checking if a message with a panic code has been placed
in the debug box, in the imx8_dsp_handle_request function from sof/imx.
If positive, the function imx8_dump, added in common, will be called.
The first step is to gather information about the registers, filename,
line number and stack by calling the imx8_get_registers, added in common.
Then the information will be printed to the console by calling the
get_status function.
Signed-off-by: Iulian Olaru iulianolaru249@yahoo.com