Repository navigation
[v2] ASoC: rt715-sdca: First version of rt715 sdw sdca codec driver. - #2299
jack-cy-yu wants to merge 0 commit into
Conversation
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
I was sometimes lost a bit, it's not clear if the code for rt715 and rt715-sdca is shared or not, sometimes it looks like yes but others not.
Also it'd be good to align on naming conventions for controls, rt711 and rt715 use different ways of exposing SDCA controls, let's try to be consistent.
and last checkpatch.pl would probably report quite a few errors with style/alignment.
Thanks @jack-cy-yu !
There was a problem hiding this comment.
we should use more normative stuff, like JACK_CODEC, SMARTMIC, HID, and they should be in a common header file.
There was a problem hiding this comment.
use SDW_SLAVE_ENTRY_EXT(), otherwise you will have a conflict with the driver handling the previous version of the hardware.
There was a problem hiding this comment.
I think it'd be good to have a consistent naming of controls across drivers. for rt711 the control name includes more information that makes it less ambiguous. Something to discuss between @shumingfan and @jack-cy-yu
There was a problem hiding this comment.
spurious line, checkpatch.pl should complain here?
Update driver according to thesofproject#2299 request. Signed-off-by: Jack Yu <jack.yu@realtek.com>
Update driver according to #2288 request.