Skip to content

ASoC: SOF: Intel: BYT: correct shim register reading - #1489

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
keyonjie:sof-dev
Nov 22, 2019
Merged

ASoC: SOF: Intel: BYT: correct shim register reading#1489
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
keyonjie:sof-dev

Conversation

@keyonjie

@keyonjie keyonjie commented Nov 14, 2019

Copy link
Copy Markdown

The shim registers in BYT/CHT/BSW are 64bits based, correct the wrong
32bits used in byt_dump().

Signed-off-by: Keyon Jie yang.jie@linux.intel.com

@keyonjie
keyonjie requested review from ranj063 and xiulipan November 14, 2019 18:33
plbossart
plbossart requested changes Nov 14, 2019
View reviewed changes
Comment thread sound/soc/sof/intel/byt.c Resolved
@keyonjie
keyonjie requested a review from plbossart November 14, 2019 19:33
ranj063
ranj063 previously approved these changes Nov 15, 2019
View reviewed changes
@keyonjie keyonjie mentioned this pull request Nov 15, 2019
Closed
@keyonjie

keyonjie commented Nov 21, 2019

Copy link
Copy Markdown
Author

@plbossart This is good to merge?

@plbossart

plbossart commented Nov 21, 2019

Copy link
Copy Markdown
Member

@plbossart This is good to merge?

no, the fixes tag is wrong

Fixes: 9e42c5c ("ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support")

@keyonjie

keyonjie commented Nov 21, 2019

Copy link
Copy Markdown
Author

@plbossart This is good to merge?

no, the fixes tag is wrong

Fixes: 9e42c5c ("ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support")

It is already like that?
Fixes: 9e42c5c ("ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support")

@plbossart

plbossart commented Nov 21, 2019

Copy link
Copy Markdown
Member

@plbossart This is good to merge?

no, the fixes tag is wrong
Fixes: 9e42c5c ("ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support")

It is already like that?
Fixes: 9e42c5c ("ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support")

I gave you the correct tag last week already.

3a9e204 (Liam Girdwood 2019-09-27 15:05:37 -0500 148) u32 st

@keyonjie

keyonjie commented Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

I gave you the correct tag last week already.

3a9e204 (Liam Girdwood 2019-09-27 15:05:37 -0500 148) u32 st

Oh shoot, my bad, didn't get your exact point during several ping-pong conservations.

@keyonjie
ASoC: SOF: Intel: BYT: fix a copy/paste mistake in byt_dump()
e8eff73 
The shim registers in BYT/CHT/BSW are 64bits based, correct the
copy/paste (from bdw.c where the shim registers are 32bits based) error
in byt_dump().

Fixes: 3a9e204 ("ASoC: SOF: Intel: Add context data to any IPC timeout")
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
plbossart
plbossart approved these changes Nov 22, 2019
View reviewed changes

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @keyonjie

@plbossart
plbossart merged commit bc30957 into thesofproject:topic/sof-dev Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossart plbossart plbossart approved these changes
@ranj063 ranj063 ranj063 approved these changes
@lgirdwood lgirdwood Awaiting requested review from lgirdwood
@xiulipan xiulipan Awaiting requested review from xiulipan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keyonjie @plbossart @ranj063