Skip to content

Add initial support for i.MX8 SOF driver - #1048

Merged
plbossart merged 3 commits into
thesofproject:topic/sof-devfrom
dbaluta:sof-dev-3
Aug 12, 2019
Merged

plbossart merged 3 commits into
thesofproject:topic/sof-devfrom
dbaluta:sof-dev-3

Conversation

@dbaluta

@dbaluta dbaluta commented Jun 18, 2019 •

Copy link
Copy Markdown
Collaborator

Hello @plbossart @ranj063 @lgirdwood
This is version 4 of the patches that add the initial DSP Linux driver for i.MX8 into SOF.

This version only contains SOF related patches and fixes review comments from @plbossart and Lucas Stach from arm mailing list:

https://lore.kernel.org/linux-arm-kernel/20190723084104.12639-1-daniel.baluta@nxp.com/

This patches would require IMX DSP interface driver (which I hope to be soon merged by Shawn Guo - imx maintainer).

https://lkml.org/lkml/2019/8/1/260

Now there is the tricky part: how do we bring all these patches together because SOF Linux driver
depends on IMX DSP. I have handled this through KConfig depenencies. So, one cannot select SOF Linux driver compilation without imx dsp.


Hello @lgirdwood @ranj063 @plbossart
This is version 3 of the patch to add the initial DSP Linux driver for i.MX8 into SOF.

For compilation you need to use the following kconfig fragment:
thesofproject/kconfig#13

I have added all patches related to DSP here in order to be able to do a proper compilation.

these patches are under review with arm64/imx community
ASoC: SOF: Add DT DSP device support
dt-bindings: dsp: fsl: Add DSP core binding support
arm64: dts: imx8qxp: Add DSP DT node

these patches need to be reviewed by SOF community
ASoC: SOF: Add DT DSP device support
ASoC: SOF: topology: Add dummy support for i.MX8 DAIs
ASoC: SOF: imx: Add i.MX8 HW support

this patch is under review:
firmware: imx: Add DSP IPC protocol interface

Patches below are already accepted into Shawn's Guo tree for i.mx8 arm.

clk: imx8: Add DSP related clocks
firmware: imx: scu-pd: Add IRQSTR_DSP PD range
firmware: imx: scu-pd: Add mu13 b side PD range
firmware: imx: scu-pd: Rename mu PD range to mu_a
arm64: dts: imx8qxp: sort LSIO subsystem devices
arm64: dts: imx8qxp: Add lsio_mu13 node


Version 2:
Hello veryone @ranj063 @plbossart @lgirdwood. This is version 2 of the PR trying to add basic support for i.MX8.

What changed since v1:

  • i tried to address all your comments. We now support only no-codec mode
  • i removed the patches related to dsp ipc / dts / pd because I have sent them separately to corresponding maintainers.

All patches are here, together with some patches for serial console to work.
https://github.com/dbaluta/linux/commits/topic/sof-dev

All this patches were sent to review, as follows:

  1. power domains related changes:

https://lkml.org/lkml/2019/7/18/252

  1. DSP IPC interface

https://lkml.org/lkml/2019/7/18/123

  1. DSP DT node

@plbossart @lgirdwood what do you think would be the appropriate way to have this reviewed with the alsa community? I guess starting the patches to alsa-devel would be the right way to do?


Version 1:
This patch series add basic support for i.MX8 SOF driver.

First 3 patches introduce DSP IPC protocol driver (review with community ongoing - https://lkml.org/lkml/2019/6/14/165)

505a33c dt-bindings: arm: fsl: Add DSP IPC binding support
00a5e98 firmware: imx: Add DSP IPC protocol driver
d2a410a mailbox: imx: Clear GIEn bit at shutdown

Next 3 patches add DT nodes corresponding to DSP. Review will be started with community soon.

15ccaaa arm64: dts: imx8qxp: Add DSP DT node
d4dfab8 arm64: dts: imx8qxp: Add DSP MU node
76760c1 clk: imx8qxp: Add DSP clocks

Next 2 patches are small SOF cleanups that can be merged as they are:

7310ddc ASoC: SOF: loader: Dont ignore SRAM block types
23159b1 ASoC: SOF: loader: Use the BAR provided by FW

Last 3 patches are the actual support for i.MX8 SOF driver.

70dd8da ASoC: SOF: Add DT DSP device support
5b28a5e ASoC: SOF: topology: Add dummy support for i.MX8 DAIs
b79c490 ASoC: SOF: imx: Add i.MX8 HW support

Would like to see some review for last 5 patches.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants