Skip to content

[FEATURE] hdmi needs to support Jack detection #912

Closed

Description

@libinyang

Currently, very little intel SOF driver support hdmi jack detection. We should add hdmi jack detection support on the intel sof platforms. It should be better to move jack support from machine drivers to hdac_hdmi.c

Activity

  1. mengdonglin commented on May 10, 2019

    @mengdonglin

    @libinyang Please list short-term/long-term opens and effort here, provide PR ww20.1

  2. libinyang commented on May 10, 2019

    @libinyang
    Author

    long term is to move jack to hdac_hdmi.c. short term is to implement in machine driver.
    Currently I will do the short term.

    And after check, our machine has some code to support jack. But it calls a wrong function, which will not create the jack.

  3. libinyang commented on May 13, 2019

    @libinyang
    Author

    Patch is submitted #935.
    I will submit the patch to community later after a draft review internally.

  4. mengdonglin commented on May 14, 2019

    @mengdonglin

    @libinyang please share UCM to Clare. @ClarexZhou please verify #935 and UCM

  5. libinyang commented on May 16, 2019

    @libinyang
    Author

    UCM has been updated to branch's branch.

  6. mengdonglin commented on May 20, 2019

    @mengdonglin

    Fixed by PR #935 that was merged

  7. ClarexZhou commented on May 20, 2019

    @ClarexZhou

    Error not seen on CML laptop with PR #935
    Environment
    Rander UCM https://github.com/RanderWang/intel-UCM/tree/hdmi
    Kernel:df06e42_ https://github.com/thesofproject/linux/tree/release/sof-v5.0
    Firmware repo: b73b9a6 https://github.com/thesofproject/sof/commits/debug-ipc-timeout 
    Topology: https://github.com/thesofproject/sof/tree/debug-ipc-timeout . Same as above SOF repo
    file: tools/topology/sof-hda-generic.m4, sof-hda-generic-2ch.tplg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions