[BUG] ASoC: cpu DAI prepare error on GLK #828

Activity

1. keqiaozhang

   added

   bugSomething isn't workingSomething isn't working

   P1Blocker bugs or important featuresBlocker bugs or important features

   br-sof-dev

   GLKApplies to Gemini LakeApplies to Gemini Lake

   on Apr 12, 2019
2. xiulipan commented on Apr 12, 2019

   

   xiulipan

   on Apr 12, 2019

   More actions

   @ranj063
   I had a quick look and the -22 should be returned form following code, right?
   

   linux/sound/soc/sof/intel/hda-dai.c

   Lines 168 to 179 in 46c2b85

   	static int hda_link_pcm_prepare(struct snd_pcm_substream *substream,
   	struct snd_soc_dai *dai)
   	{
   	struct snd_soc_pcm_runtime *rtd = substream->private_data;
   	struct snd_sof_dev *sdev =
   	snd_soc_component_get_drvdata(dai->component);
   	struct snd_sof_pcm *spcm;
   	int stream = substream->stream;
   	spcm = snd_sof_find_spcm_dai(sdev, rtd);
   	if (!spcm)
   	return -EINVAL;

   @ranj063
   And any idea if we will need to find BE from snd_sof_find_spcm_dai?

   @xiulipan no, if you look at sof_load_dai(), we dont create spcm for a BE.

   Originally posted by @ranj063 in #816 (comment)

   If snd_sof_find_spcm_dai is not designed for find BE, why we are using it here?
3. keqiaozhang commented on Apr 12, 2019

   

   keqiaozhang

   on Apr 12, 2019

   Author

   More actions

   Add more logs

   [  102.777150] sof-audio-pci 0000:00:0e.0: ipc tx succeeded: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
   [  102.777153] sof-audio-pci 0000:00:0e.0: pcm: stream dir 0, posn mailbox offset is 790528
   [  102.777170] sof-audio-pci 0000:00:0e.0: PXL: pcm id 7 | rtd id 3
   [  102.777172] sof-audio-pci 0000:00:0e.0: PXL: pcm id 6 | rtd id 3
   [  102.777174] sof-audio-pci 0000:00:0e.0: PXL: pcm id 5 | rtd id 3
   [  102.777176] sof-audio-pci 0000:00:0e.0: PXL: pcm id 99 | rtd id 3
   [  102.777177] sof-audio-pci 0000:00:0e.0: PXL: pcm id 1 | rtd id 3
   [  102.777179] sof-audio-pci 0000:00:0e.0: PXL: pcm id 0 | rtd id 3
   [  102.777181] sof-audio-pci 0000:00:0e.0: ASoC: cpu DAI prepare error: -22
   [  102.777183]  iDisp1: ASoC: backend prepare failed -22
   

   diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h
   index 35e78ffecce2..f3c7122b7474 100644
   --- a/sound/soc/sof/sof-priv.h
   +++ b/sound/soc/sof/sof-priv.h
   @@ -481,6 +481,7 @@ struct snd_sof_pcm *snd_sof_find_spcm_dai(struct snd_sof_dev *sdev,
           struct snd_sof_pcm *spcm = NULL;
   
           list_for_each_entry(spcm, &sdev->pcm_list, list) {
   +               dev_err(sdev->dev, "PXL: pcm id %zu | rtd id %zu\n",spcm->pcm.dai_id, rtd->dai_link->id);
                   if (le32_to_cpu(spcm->pcm.dai_id) == rtd->dai_link->id)
                           return spcm;
           }
4. mengdonglin

   assigned

   ranj063

   on Apr 12, 2019
5. mengdonglin

   added

   WHLApplies to WhiskeyLake platformApplies to WhiskeyLake platform

   CMLApplies to Comet Lake platformApplies to Comet Lake platform

   HDAApplies to HD-Audio bus for codec connectionApplies to HD-Audio bus for codec connection

   on Apr 12, 2019
6. ranj063 commented on Apr 12, 2019

   

   ranj063

   on Apr 12, 2019

   Collaborator

   More actions

   If snd_sof_find_spcm_dai is not designed for find BE, why we are using it here?

   @xiulipan ack. working on it. will get back asap.
7. libinyang commented on Apr 13, 2019

   

   libinyang

   on Apr 13, 2019

   More actions

   it seems the regression of #795?
8. mengdonglin commented on Apr 15, 2019

   

   mengdonglin

   on Apr 15, 2019

   More actions

   Can be fixed by PR #834, waiting for fixing CI error and getting merged.
9. plbossart

   closed this as completedin #880on Apr 29, 2019
10. kv2019i

    added a commit that references this issue on Jan 19, 2021

    iommu/vt-d: Fix lockdep splat in sva bind()/unbind()

    ...

    420d42f
11. IulianOlaru249

    added a commit that references this issue on Mar 16, 2022

    iommu/vt-d: Fix lockdep splat in sva bind()/unbind()

    ...

    a4c84cd