Topology: Need to manage multiple configurations per DAI #697

Activity

1. plbossart

   added

   enhancementNew feature or requestNew feature or request

   on Mar 6, 2019
2. wenqingfu

   assigned

   wenqingfu

   and

   fredoh9

   and unassigned

   wenqingfu

   on Mar 21, 2019
3. fredoh9 commented on Mar 22, 2019

   

   fredoh9

   on Mar 22, 2019

   Collaborator

   More actions

   Interesting issue. I'm not quite sure what change in kernel driver is required at this moment, but I will review at full stacks, driver/topology files/firmware. I will come up with the solution.
4. lgirdwood commented on Mar 22, 2019

   

   lgirdwood

   on Mar 22, 2019

   Last edited by lgirdwood

   Member

   More actions

   @fredoh9 ASoC topology supports this already but is likely untested. You will need too

   Driver

   1. Write a simple topology with one DAI that has 2 or more configs.
   2. Make sure the alsatplg compiler adds both configs in the binary file.
   3. make sure sound/soc/topology.c parses both DAI configs.
   4. Make sure sound/soc/sof/topology.c parses both configs and send IPC for both configs.

   Firmware

   1. FW should receive both configs and add to dai.c (only one supported today, we can have a list of configs)
   2. By default FW will use config 0. @keyonjie is working on logic to select the best config based on stream params and topology. We may also need to add a manual config selection method too.
5. fredoh9 commented on Mar 23, 2019

   

   fredoh9

   on Mar 23, 2019

   Collaborator

   More actions

   @lgirdwood wow, thank you for detailed guideline. Will work on it.
6. wenqingfu commented on Mar 28, 2019

   

   wenqingfu

   on Mar 28, 2019

   More actions

   @fredoh9 #758 may close this ticket
7. dragosht commented on Mar 29, 2019

   

   dragosht

   on Mar 29, 2019

   Last edited by dragosht

   More actions

   @wenqingfu Actually #758 simply acknowledges the presence of multiple configs but adds an additional check for the assigned default hardware configuration and chooses that one to be send to the firmware. I think it is more work involved with this issues than just that. And based on @lgirdwood 's notes above, all the hardware configs should eventually be sent to the firmware via IPC, but first the firmware would need some reworks to allow handling multiple configurations on the same DAI.
8. plbossart commented on Jun 16, 2021

   

   plbossart

   on Jun 16, 2021

   MemberAuthor

   More actions

   we have a multi-configuration support for SSP, let's close this.
9. plbossart

   closed this as completedon Jun 16, 2021
10. oder-chiou

    added a commit that references this issue on May 5, 2026

    jbd2: fix assertion 'jh->b_frozen_data == NULL' failure when journal …

    ...

    4a734f0