Repository navigation
xrun handling should be handled by alsa instead of firmware #660
Description
Currently the driver assumes the xrun will be handled by the firmware.
Ultimately it should be handled by alsa itself by simply restarting the stream, since firmware isn't capable of resetting DMA pointers.
Activity
mengdonglin commentedon Feb 18, 2019
thesofproject/sof#851 is to add support for ALSA xrun recovery in firmware side and also needs a kernel config DEBUG_XRUN_STOP=y
plbossart commentedon Mar 4, 2019
@slawblauciak What you describe is the standard ALSA xrun handling, not sure what is needed in the SOF-specific parts?
wenqingfu commentedon May 13, 2019
are we done with this topic? @keyonjie
keyonjie commentedon May 14, 2019
@wenqingfu I think so, to move to ALSA Xrun handling, we should define NO_XRUN_RECOVERY in FW and select CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP in driver(or add this to FW_READY struct later), but as we haven't defined NO_XRUN_RECOVERY in FW yet, so QA haven't verified this.
So in short sentence, let's say we still have half day's work(add it to FW_READY and remove CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP item in kernel) remained for developing.
plbossart commentedon Jan 9, 2020
@slawblauciak @keyonjie can we close this, it's been stale for 8 months now?
keyonjie commentedon Jan 9, 2020
@plbossart I think so, as we already set NO_XRUN_RECOVERY in FW by default, and in driver CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP is not selected by default. Let me close it.
dma-mapping: use IOMMU DMA calls for common alloc/free page calls