Skip to content

CI: Need to trap SOF driver compilation warnings #205

Closed

Description

@plbossart

Our esteemed developers don't seem to look at the kernel compilation logs, as a result we have patches that are merged even when they generate warnings such as

 CC [M]  sound/soc/sof/trace.o
sound/soc/sof/trace.c: In function ‘snd_sof_init_trace_ipc’:
sound/soc/sof/trace.c:155:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type]
   return;
   ^~~~~~
sound/soc/sof/trace.c:148:5: note: declared here
 int snd_sof_init_trace_ipc(struct snd_sof_dev *sdev)
     ^~~~~~~~~~~~~~~~~~~~~~

We need the CI build to trap such errors and flag them as errors.

Activity

  1. xiulipan commented on Oct 24, 2018

    @xiulipan

    @mengdonglin
    Who is the maintainer of the 0-day CI?

    @plbossart
    Would you like to enable a Travis CI for this kernel repo? It will involve file .travis.yml into the repo.

  2. cujomalainey commented on Oct 24, 2018

    @cujomalainey

    @xiulipan if you use Travis there is a very good chance that we can find another yml file already configured for this

  3. xiulipan commented on Oct 24, 2018

    @xiulipan

    @cujomalainey
    For Linux I believe there are must a lot of yml file.
    We can modify some to meet our requirement here.

    Another problem is how to get config.

  4. mengdonglin commented on Oct 24, 2018

    @mengdonglin

    @xiulipan Fuwei has enabled trapping the compilation warnings in 0-day CI.

    It will be great if Travis CI can support kernel. @plbossart would you recommend a kconfig?

  5. plbossart commented on Oct 24, 2018

    @plbossart
    MemberAuthor

    @mengdonglin it's fine to use the same kconfig as 0day. Alternatively we could use the fragments that are already managed at https://github.com/thesofproject/kconfig for faster compilation.

  6. xiulipan commented on Dec 17, 2018

    @xiulipan

    @plbossart
    Enabled with #351

  7. wenqingfu commented on Feb 27, 2019

    @wenqingfu

    close as #351 fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions