Skip to content

Separate .init and .text memory bounds - #790

Merged
kevinaboos merged 1 commit into
theseus-os:theseus_mainfrom
tsoutsman:separate-text-init
Jan 9, 2023
Merged

kevinaboos merged 1 commit into
theseus-os:theseus_mainfrom
tsoutsman:separate-text-init

Conversation

@tsoutsman

Copy link
Copy Markdown
Member

Since they are two different program segments, there are no guarantees that the bootloader will allocate them contiguously in physical memory.

Signed-off-by: Klim Tsoutsman klim@tsoutsman.com

Since they are two different program segments, there are no guarantees
that the bootloader will allocate them contiguously in physical memory.

Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
tsoutsman requested a review from kevinaboos January 6, 2023 10:35
@tsoutsman tsoutsman mentioned this pull request Jan 8, 2023

@kevinaboos kevinaboos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 left one small question

Comment thread kernel/memory/src/paging/mod.rs Resolved

@kevinaboos kevinaboos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kevinaboos
kevinaboos merged commit aa83820 into theseus-os:theseus_main Jan 9, 2023
github-actions Bot pushed a commit that referenced this pull request Jan 9, 2023
`.init` and `.text` are two different program segments in the base kernel image;
they are not guaranteed to be loaded contiguously in physical memory
by the bootloader. Thus, instead of assuming/requiring them to be
physically contiguous, we only expect that they're virtually contiguous. aa83820
kevinaboos pushed a commit to amab8901/Theseus that referenced this pull request Jan 9, 2023
`.init` and `.text` are two different program segments in the base kernel image;
they are not guaranteed to be loaded contiguously in physical memory
by the bootloader. Thus, instead of assuming/requiring them to be
physically contiguous, we only expect that they're virtually contiguous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants