Repository navigation
Conversation
Author
|
If you would like to provide feedback on this PR, feel free to leave a comment. |
Contributor
|
Do you think it's feasible to achieve this using metaprogramming to avoid repeated code (one implementation for async one for sync)? |
Contributor
|
Are we need async implementation for testing purposes? |
Contributor
|
I'm going to close this PR for now. The main reason is that the benefits of async only manifest in the async implementation of sqlalchemy. In particular, none of the container-related code uses Feel free to disagree, and we can discuss reopening this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the core code prepared for asynchronous processing in Python.
Asynchronous processing using the asyncio module is supported from SQLAlchemy version 1.4.
(https://docs.sqlalchemy.org/en/14/orm/extensions/asyncio.html)
So, in order to use these asynchronous modules in testcontainers, we make a PR request for the code that supports these modules.
In addition to PostgreSQL, other relational DB drivers can also support it, and a parameter has been added to the function to select Dialect in the existing code.
(Python uses several DB driver, so I don't think it's good to hardcode a specific driver #140)