Bug: Docker image build kwargs is not working #706

Activity

1. Tranquility2 commented on Oct 1, 2024

   

   Tranquility2

   on Oct 1, 2024

   ContributorAuthor

   More actions

   class DockerImage:
   ...
       def __init__(
           self,
           path: Union[str, PathLike],
           docker_client_kw: Optional[dict] = None,
           tag: Optional[str] = None,
           clean_up: bool = True,
           dockerfile_path: Union[str, PathLike] = "Dockerfile",
           no_cache: bool = False,
           **kwargs,
       ) -> None:
   ...
       def build(self, **kwargs) -> Self:
           logger.info(f"Building image from {self.path}")
           docker_client = self.get_docker_client()
           self._image, self._logs = docker_client.build(
               path=str(self.path), tag=self.tag, dockerfile=self._dockerfile_path, nocache=self._no_cache, **kwargs
           )
           logger.info(f"Built image {self.short_id} with tag {self.tag}")
           return self
   ...
       def __enter__(self) -> Self:
           return self.build()

   As can be seen kwargs is not passed/used correctly...
   This is ofc my bad, sorry.
   Will create a fix asap.

   maybe also take the time to add something like #614
2. Tranquility2 commented on Oct 1, 2024

   

   Tranquility2

   on Oct 1, 2024

   ContributorAuthor

   More actions

   Workaround

   Just use the lower level methods

   def test_something():
       image = DockerImage(path="./", tag="new:test")
       image.build(buildargs={"PIP_EXTRA_INDEX_URL": PIP_EXTRA_INDEX_URL})
       with AWSLambdaContainer(image=image, port=8080) as func:
          # Do Something with the container
       image.remove()
3. kiview

   added

   🐛 bug

   on Oct 1, 2024
4. black-snow commented on Oct 1, 2024

   

   black-snow

   on Oct 1, 2024

   Contributor

   More actions

   I feel like this was my original issue with build args exactly :D

   👍React with 👍1Reacted by Roy Moore
5. alexanderankin

   closed this as completedin #708on Apr 2, 2025
6. alexanderankin

   closed this as completedin cc02f94on Apr 2, 2025
7. Tranquility2

   added a commit that references this issue on Apr 4, 2025

   fix(core): Add kwargs to image build (testcontainers#708)

   ...

   This issue will close once commit cc02f94 is merged into the 'main' branch.

   cc02f94