Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

README.md markdown highlight - #2033

Closed
olramde wants to merge 2 commits into
tensorflow:masterfrom
olramde:ReadmeUpdate
Closed

olramde wants to merge 2 commits into
tensorflow:masterfrom
olramde:ReadmeUpdate

Conversation

@olramde

@olramde olramde commented Jul 23, 2020 •

Copy link
Copy Markdown
Contributor

Description

Code highlights applied to README.md

Fixes # (issue)

Type of change

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

@bhack
bhack self-requested a review July 23, 2020 11:58

@bhack bhack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On which tool the Markdown formatting was done?

@olramde

olramde commented Jul 23, 2020

Copy link
Copy Markdown
Contributor Author

마크 다운 형식화는 어떤 도구에서 수행 되었습니까?

done in prettier

@bhack

bhack commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

If you want this or something like this I think It Is better that you open a separate ticket to collect consensus on introducing a Markdown linter/formatter pass as there are many solutions.
Using the tool locally don't help us to have an homogenus approach.
E.g. see #1808

@seanpmorgan

Copy link
Copy Markdown
Member

Agree with @bhack here. If we want to lint our markdown files lets discuss agree on a formatter in a seperate issue first. Closing for now.

@olramde
olramde deleted the ReadmeUpdate branch July 23, 2020 15:42
@olramde

olramde commented Jul 23, 2020

Copy link
Copy Markdown
Contributor Author

Thank You!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants