Repository navigation
Don't hang worker shutdown when worker validation fails - #2023
Open
parbhatkapila4 wants to merge 1 commit into
Open
parbhatkapila4 wants to merge 1 commit into
parbhatkapila4 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Worker.run() fails validation, for example because the namespace doesn't exist, _run() raises before it gets to the shutdown steps, so _shutdown_complete_event is never set. Calling shutdown() after that waits forever, even though the run() docstring says it's harmless to call. async with Worker(...) hits the same thing: the worker cancels the block to report the error, aexit calls shutdown(), and it hangs instead of raising the validation error. So a typo in the namespace freezes the app with no error.
Now a failed validation marks shutdown complete before re-raising, as long as the worker hadn't already started. shutdown() returns right away, and async with raises "Worker validation failed".
Added a test next to test_worker_validate_fail that covers both shutdown() after a failed run() and async with. On main, shutdown() doesn't finish within 10 seconds. With the fix, it passes.