Repository navigation
Add Support for Language-Independent AD Group Identification Using SIDs #22
Description
Hi @techspence,
First off, great script! I came across it after reading your blog post, and I’m really impressed.
I have one suggestion to make it more versatile across Active Directory (AD) environments with different language settings. Currently, the script uses hardcoded English group names, which may not work in non-English AD setups.
It would be fantastic if you could modify the script to use the Security Identifier (SID) for default admin groups, as these remain consistent regardless of language.
Thanks again for your work on this!
Best,
Barne
Activity
[-]english group names not working in non english domains[/-][+]Add Support for Language-Independent AD Group Identification Using SIDs[/+]techspence commentedon Nov 1, 2024
Hey @Barneee thanks so much for the kind words!
You are absolutely right. That should be pretty easy to do. I can probably steal Jake's code, he won't mind. 😋 https://github.com/TrimarcJake/Locksmith/blob/252b050dbb8331befa2473c79507d1d8eefdb0e1/Public/Invoke-Locksmith.ps1#L164
That being said if you're at all interested in a PR feel free. Otherwise, I will add this to my late-night todo list to get done sometime soon. 😀