Repository navigation
Fix test warnings - #1893
Open
bcantoni wants to merge 2 commits into
Open
Fix test warnings#1893bcantoni wants to merge 2 commits into
bcantoni wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrow and consistent with their stated purpose, with no blocking issues identified.
0 open findings
What changed in this PR
Cleans up test warnings and corrects documentation escapes without changing runtime behavior.
Changes:
- Sets API version 3.0 for asynchronous publishing timeout tests.
- Updates pytest parameterization and adds targeted warning filters.
- Corrects backslash escapes in request-filter documentation.
| File | Description |
|---|---|
| test/test_workbook.py | Sets the API version for the asynchronous timeout test. |
| test/test_site.py | Adds warning filters and materializes parameter combinations. |
| test/test_datasource.py | Sets the API version for the asynchronous timeout test. |
| tableauserverclient/server/request_options.py | Fixes escapes in docstring examples. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up some existing warnings that come up when running tests:
All changes from Codex