You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
builder.bundle -> options -> uglify -> beautify should be called **output** #689
Since you are providing a way to pass options to Uglify directly (separate from SystemJS Builder defaults) these should be consistent with UglifyJS.minify(). minify() has no option beautify but has output^. This is passed in your code to ast.print_to_string(outputOptions) which is the same as what minify does internally$ except for this name discrepancy. See lines 106-113 in lib/output.js.
To be consistent with uglifyJS this must be changed.
^ output has an option beautify inside.
$ print_to_string() is a wrapper for function OutputStream() which is what minify invokes directly.
Activity
guybedford commentedon Sep 13, 2016
Thanks for pointing this out. A PR here to ensure better consistency is very welcome.
guybedford commentedon Oct 25, 2016
We should likely also include mangle here as in #708.