Skip to content
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
This repository was archived by the owner on Oct 9, 2020. It is now read-only.

builder.bundle -> options -> uglify -> beautify should be called **output** #689

Open

Description

@CxRes

Since you are providing a way to pass options to Uglify directly (separate from SystemJS Builder defaults) these should be consistent with UglifyJS.minify(). minify() has no option beautify but has output^. This is passed in your code to ast.print_to_string(outputOptions) which is the same as what minify does internally$ except for this name discrepancy. See lines 106-113 in lib/output.js.

To be consistent with uglifyJS this must be changed.

^ output has an option beautify inside.
$ print_to_string() is a wrapper for function OutputStream() which is what minify invokes directly.

Activity

  1. guybedford commented on Sep 13, 2016

    @guybedford
    Member

    Thanks for pointing this out. A PR here to ensure better consistency is very welcome.

  2. guybedford commented on Oct 25, 2016

    @guybedford
    Member

    We should likely also include mangle here as in #708.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions