Repository navigation
Keep the Linux overrides to the Linux tests - #335
Merged
Merged
Conversation
`linux_version_overrides` also reached the Static SDK, Wasm, Embedded Wasm and Android builds and the Cxx interop check, so an adopter that set warnings as errors for its tests, as swift-nio-http2 does, found it applied to jobs that had never carried it. The existing workflows gave those jobs only the global `swift_flags`. The SDK builds take their per-version overrides only from their own `*_sdk_version_overrides` input, the Cxx interop check takes none, and the Linux overrides name versions the Linux tests run. The tests that asserted the sharing now assert its absence.
FranzBusch
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux_version_overridesalso reached the Static SDK, Wasm, Embedded Wasm and Android builds and the Cxx interop check, so an adopter that set warnings as errors for its tests would see it apply to more than intended. The existing workflows gave those jobs only the globalswift_flags.The SDK builds take their per-version overrides only from their own
*_sdk_version_overridesinput, the Cxx interop check takes none, and the Linux overrides name versions the Linux tests run. The tests that asserted the sharing now assert its absence.