Repository navigation
Only read the PE header when verifying downloaded Windows installers - #330
Merged
FranzBusch merged 1 commit intoOct 26, 2026
Merged
Conversation
The download check read the whole installer with ReadAllBytes just to look at the first two bytes. ReadAllBytes throws on files over 2 GB, and the nightly-main Windows toolchain installer is now 2087 MB, so every attempt fails with "The file is too long" and the Install Swift step gives up after 5 retries. Open the file and read only the two-byte MZ header instead. The same check in install-vsb.ps1 gets the same fix.
FranzBusch
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download check read the whole installer with
ReadAllBytesjust to look at the first two bytes.ReadAllBytesthrows on files over 2 GB, and thenightly-mainWindows toolchain installer is now 2087 MB, so every attempt fails with "The file is too long".Open the file and read only the two-byte MZ header instead.