Repository navigation
refactor(cli): cover the auth and config areas with effect lint (CLI-2740) - #7212
Merged
7ttp merged 2 commits intoOct 19, 2026
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed with no findings. My review of the diff and surrounding code found no additional issues; fixture timing, service wiring, assertions, and error behavior are preserved. Tests were not run because dependencies are absent.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…7ttp/cli-2740-srcauth-srcconfig-areas-coverage
An error occurred while trying to automatically change base from
7ttp/cli-2741-srctelemetry-area-coverage-command
to
7ttp/cli-2741-srctelemetry-area-coverage-state
October 19, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings the
authandconfigareas under the effect lint, tests includedwhats introduced?
auth/**andconfig/**join the allow listcommand-platform-apiandproject-refyield their errors directly instead of throughEffect.fail, with the same errors and messagesnode:fs,node:path,JSONandDateforuseTempWorkdir, theFileSystemandPathservices, schema codecs andDateTime, and the hand rolled fs and path fakes in thecommand-platform-apitest goref