Repository navigation
chore(cli): map pull command permissions - #7180
Merged
Merged
Conversation
pull composes the config-pull, database and function-download blocks directly. The steps after the config read run only without --dry-run, so they carry an is: false condition on it. The database steps always receive the resolved ref, so the pooler fetch needs no --project-ref and gets its own entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The real database config resolver and linked-project cache now run in the pull tests, so the drift check sees the pooler, login role, config, function and cache calls. Covers a bootstrap run with and without --project-ref, --dry-run, the project picker and the IPv6 retry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed and reported no findings. Reading the changed files, handler, shared permission blocks, and test helpers supports that result: the declarations cover dry-run behavior, resolved project refs, cache fills, and pooler fallback. No fundamental conflict with the supplied next-branch work was identified. Tests were not run during adjudication.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
jgoux
approved these changes
Oct 15, 2026
…on-map-pull # Conflicts: # apps/cli/tests/helpers/permission-pending-commands.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps the top-level
pullcommand to the Management API operations it calls.pullcomposes the config-pull, linked-project cache, database config and function-download blocks directly, because its sub-commands' declarations describe different flags and gating. The database and function steps are gated on--dry-runbeing false, since a dry run stops after the target and config reads.pullalso declares its own pooler-config entry: its database steps always get the resolved ref, so the pooler fetch happens without--project-ref.Findings: a bootstrap run resolves the database twice, so it fetches the pooler config and mints a login role twice; step failures are isolated but
pullstill fails, so every step call is required.Untested conditions: a declined confirmation (it over-declares, like
--dry-run), a failing step under the real layers, and a branch-name target under the real layers.dbConfigLinked,dbConfigPoolerFallbackLinkedand the own pooler entry overlap, so dropping one alone fails no test. No blocks without a real-layer test, no best-effort label turned required, noOPERATIONS_WITHOUT_FGAentries.🤖 Generated with Claude Code