Repository navigation
Conversation
trange rounded start and duration separately, so a segment placed exactly at the previous segment's end could come out 1us before it and raise SegmentOverlap. Round start and end instead and derive the duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
trangenow rounds the start and the end, then takes the difference as the duration. That way a clip that starts where the previous one ended always lines up exactly. String inputs like"1.5s"still parse the same way.timis unchanged. It just uses a new helper that returns the unrounded value.I added
tests/test_time_util.py. Without the fix, 18 of its cases fail. The repro from the issue now runs clean for 32 bars.The 3 failures in
tests/test_draft_profiles.pyhappen onmaintoo (Windows drive path tests running on macOS), so they're unrelated.