Create logfwd-input crate, move file tailer + IO #265

Activity

1. strawgate

   added

   enhancementNew feature or requestNew feature or request

   on Mar 30, 2026
2. strawgate

   self-assigned this

   on Mar 30, 2026
3. strawgate commented on Mar 30, 2026

   

   strawgate

   on Mar 30, 2026

   OwnerAuthor

   More actions

   @copilot This is a mechanical file move. Create crates/logfwd-input/ and move tail.rs, input.rs, checkpoint.rs from crates/logfwd-core/src/. Update all imports across the workspace. No backward compat needed — just update the import paths everywhere. All existing tests must pass.

   Read dev-docs/DIRECTION.md and dev-docs/CRATE_RULES.md for context on the crate restructuring.
4. strawgate commented on Mar 31, 2026

   

   strawgate

   on Mar 31, 2026

   OwnerAuthor

   More actions

   @copilot Step 1 (logfwd-arrow) has merged. You can now do Step 2.

   Create crates/logfwd-input/ and move IO-dependent code out of logfwd-core. No backward compatibility needed — just move files and update all imports.

   Files to move:

   • crates/logfwd-core/src/tail.rs → crates/logfwd-input/src/tail.rs
   • crates/logfwd-core/src/input.rs → crates/logfwd-input/src/input.rs
   • crates/logfwd-core/src/checkpoint.rs → crates/logfwd-input/src/checkpoint.rs

   Steps:

   1. Create crates/logfwd-input/Cargo.toml with these deps:

      [package]
      name = "logfwd-input"
      version = "0.1.0"
      edition = "2024"
      publish = false
      
      [dependencies]
      logfwd-core = { path = "../logfwd-core" }
      crossbeam-channel = "0.5"
      glob = "0.3"
      memchr = "2"
      notify = "7"
      serde = { workspace = true }
      serde_json = "1"
      xxhash-rust = { version = "0.8", features = ["xxh32", "xxh64"] }

   2. Create crates/logfwd-input/src/lib.rs with pub mod tail; pub mod input; pub mod checkpoint;

   3. Move the three files, update use crate:: to use logfwd_core:: where they reference core types (like filter_hints)

   4. Remove pub mod tail;, pub mod input;, pub mod checkpoint; from crates/logfwd-core/src/lib.rs

   5. Delete the old files from logfwd-core

   6. Remove now-unused deps from logfwd-core's Cargo.toml: crossbeam-channel, glob, notify, serde_json, xxhash-rust (check each is truly unused first)

   7. Add logfwd-input = { path = "../logfwd-input" } to workspace members in root Cargo.toml

   8. Add logfwd-input as dependency to crates that import these modules (logfwd binary, logfwd-bench if applicable)

   9. Update ALL imports across the workspace: logfwd_core::tail → logfwd_input::tail, etc.

   10. cargo test and cargo clippy -- -D warnings must pass.

   Read dev-docs/DIRECTION.md for context.
5. strawgate

   changed the title [-]Phase 1b: Create logfwd-input crate, move file tailer + IO[/-] [+]Create logfwd-input crate, move file tailer + IO[/+] on Mar 31, 2026
6. strawgate commented on Mar 31, 2026

   

   strawgate

   on Mar 31, 2026

   OwnerAuthor

   More actions

   Superseded by logfwd-io crate created in PR #375. IO modules moved there.
7. strawgate

   closed this as completedon Mar 31, 2026