Repository navigation
[6.x] Only check the selected site when building the navigation sidebar items - #15668
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the CP gets slower the more sites you have, on every page.
When building the Navigation section of the sidebar,
CoreNavcalls$nav->sites()for each navigation to see if it has a tree in the selected site.sites()loads the tree for every configured site, so with 1,218 sites and 3 navigations that's thousands of tree lookups (and queries with the Eloquent driver) per request.This PR fixes it by using
$nav->existsIn()instead, which only looks up the tree for the selected site. It's the same approach as #14988.Fixes #15667