Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the avatar in the CP header is a broken image when the user's avatar asset lives in a private container.
The header reads the user from
JavascriptComposer::user(), which passes the augmented user to the front end. Thereavataris the augmented asset, and itspermalinkisnullbecause private containers have no URL, so the<img>gets nosrc.This PR fixes it by setting
avatarto$user->avatar(), which returns the CP thumbnail URL (or the Gravatar fallback). The Users listing already uses it, and the Avatar component already accepts a string.avatar()used to throw when the avatar field augments to a query (nomax_files: 1, oralways_augment_to_queryenabled). Now that it runs on every CP page, it takes the first asset from the query instead.Fixes #15605