Skip to content

fix(proto): threat warnings as errors - #14020

Merged
janisz merged 1 commit into
masterfrom
proto_warnings_as_errors
Jan 29, 2025
Merged

janisz merged 1 commit into
masterfrom
proto_warnings_as_errors

Conversation

@janisz

@janisz janisz commented Jan 29, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR threats warnings as errors in proto files. Before we could see message but command finished with success

api/v1/alert_service.proto:10:1: warning: Import google/protobuf/timestamp.proto is unused.

now after a message we see a failure

make/protogen.mk:191: recipe for target 'github.com/stackrox/stackrox/generated/api/v1/process_listening_on_port_service.pb.go' failed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
janisz requested review from a team, mtodor and rhybrillou January 29, 2025 10:11
@rhacs-bot

Copy link
Copy Markdown
Contributor

Images are ready for the commit at db1f7b6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-564-gdb1f7b6171.

@codecov

codecov Bot commented Jan 29, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.89%. Comparing base (9e0eaa2) to head (db1f7b6).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14020      +/-   ##
==========================================
- Coverage   48.89%   48.89%   -0.01%     
==========================================
  Files        2499     2499              
  Lines      180796   180796              
==========================================
- Hits        88396    88395       -1     
- Misses      85378    85379       +1     
  Partials     7022     7022              
Flag Coverage Δ
go-unit-tests 48.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Jan 29, 2025
@janisz
janisz merged commit 9952362 into master Jan 29, 2025
@janisz
janisz deleted the proto_warnings_as_errors branch January 29, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants