Repository navigation
fix(proto): threat warnings as errors - #14020
Merged
Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
rhybrillou
approved these changes
Jan 29, 2025
Contributor
|
Images are ready for the commit at db1f7b6. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14020 +/- ##
==========================================
- Coverage 48.89% 48.89% -0.01%
==========================================
Files 2499 2499
Lines 180796 180796
==========================================
- Hits 88396 88395 -1
- Misses 85378 85379 +1
Partials 7022 7022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR threats warnings as errors in proto files. Before we could see message but command finished with success
now after a message we see a failure
Add --fatal_warnings flag to treat warnings as errors protocolbuffers/protobuf#8131
CHANGELOG update is not needed
Documentation is not needed
Testing
Automated testing
How I validated my change
CI