Repository navigation
Improve JdbcClient to align BatchSpec with StatementSpec - #37307
Conversation
sbrannen
left a comment
There was a problem hiding this comment.
Thanks for the suggestions and the PR.
I've requested a small fix.
sbrannen
left a comment
There was a problem hiding this comment.
The new tests in JdbcClientIntegrationTests use add() more than once, resulting in a multi-statement batch update. However, the new unit tests in JdbcClientIndexedParameterTests and JdbcClientNamedParameterTests only have a single add(), resulting in a single-statement batch.
Please introduce additional unit tests analogous to the current new ones but with multiple statements (e.g., 2) per batch update, and verify setObject(...) is invoked with the right values for both rows in order, plus containsExactly(...).
Updated tests with |
689f95b to
1262831
Compare
sbrannen
left a comment
There was a problem hiding this comment.
Thanks for making the requested changes.
I have now requested an additional minor simplification.
|
This has been merged into Thanks |
Add missing methods:
param(int jdbcIndex, @Nullable Object value)param(int jdbcIndex, @Nullable Object value, int sqlType)param(String name, @Nullable Object value, int sqlType)