Repository navigation
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
@sbrannen, could you please take a look at the direction here? This PR addresses the existing TODO by migrating the test from I also made sure to preserve the existing gh-22638 coverage for ResponseBodyAdvice. Since Jackson 2 support is planned to be removed in 7.2, could you advise whether migrating I'm happy to adjust the PR based on your feedback. |
Migrate RequestMappingHandlerAdapterTests#responseBodyAdvice from the deprecated MappingJackson2HttpMessageConverter to JacksonJsonHttpMessageConverter. The test advice now implements ResponseBodyAdvice directly and returns a map body that is written by the selected converter. This maintains the test coverage for spring-projectsgh-22638, verifying that a ControllerAdvice implementing both ResponseBodyAdvice and RequestBodyAdvice is not registered twice. Signed-off-by: Sunghyun Shin <froggy0m0a@gmail.com>
bclozel
added
type: task
bclozel
force-pushed
the
migrate-response-body-advice-jackson-json
branch
from
September 4, 2026 16:23
930981b to
19fdc0b
Compare
Contributor
Author
|
Thanks for reviewing and merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
responseBodyAdvicetest to use the Jackson 3 converter (JacksonJsonHttpMessageConverter) in place of the deprecated Jackson 2 converter.