Skip to content

[WIP] Paste support - #197

Closed
saket wants to merge 4 commits into
splitwise:masterfrom
saket:feature/paste-support
Closed

saket wants to merge 4 commits into
splitwise:masterfrom
saket:feature/paste-support

Conversation

@saket

@saket saket commented Jan 17, 2016

Copy link
Copy Markdown

This was pretty easy to do. Enabling long-press was all I had to do to make the context menu show up. The pasted text gets inserted into the field, triggering suggestions.

TODO
  1. This breaks the allowDuplicates feature. @mgod Please see 6317aee
  2. Support pasting of multiple tokens (separated by delimiters) in one go. My implementation assumes that the user will only paste text for one token at a time.

@dkadrikj

Copy link
Copy Markdown

Any updates merging this and releasing it?

@saket

saket commented Mar 28, 2016

Copy link
Copy Markdown
Author

@dkadrikj This is blocked on me. This PR does not support handling pastes of multiple tokens. I've added it to my project but in a very messy way. Will try cleaning it and adding it to this PR.

@niteshreddy

Copy link
Copy Markdown

@Saketme any updates ? :)

@saket

saket commented Apr 20, 2016

Copy link
Copy Markdown
Author

@niteshreddy In between changing jobs, so haven't gotten enough time to work on this. I can, however, help you make this work in your app if you want :)

@niteshreddy

Copy link
Copy Markdown

@Saketme I will take you up on that offer. @Saketme I will take that offer if you are still up for it.

@saket

saket commented May 12, 2016

Copy link
Copy Markdown
Author

@niteshreddy To start with, you can simply implement the changes I've made in this PR.

@mgod
mgod force-pushed the master branch 2 times, most recently from bdb918d to 6bc7cd4 Compare August 24, 2017 19:40
@saket saket closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants