Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

port: [#4309] AdaptiveExpression Bool function is not very useful because it doesn't convert anything but ints (#6431) - #320

Closed
erquirogasw wants to merge 1 commit into
mainfrom
southworks/port/adaptive-expression-bool-function-is-not-very-useful
Closed

erquirogasw wants to merge 1 commit into
mainfrom
southworks/port/adaptive-expression-bool-function-is-not-very-useful

Conversation

@erquirogasw

@erquirogasw erquirogasw commented Sep 2, 2022 •

Copy link
Copy Markdown

Fixes # 4309
#minor

Description

This PR ports the changes in botbuilder-dotnet to evaluate 'true' and 'false' strings.

Specific Changes

  • Updated func() method of AdaptiveExpressions/BuiltinFunctions/bool to evaluate 'false' string
  • Updated AdaptiveExpressions/Tests/expressionParser.test.js

Testing

This image shows the unit tests passing.
image

@coveralls

coveralls commented Sep 2, 2022 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2979762039

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 84.532%

Totals Coverage Status
Change from base Build 2933847103: -0.001%
Covered Lines: 19871
Relevant Lines: 22267

💛 - Coveralls

@sw-joelmut

Copy link
Copy Markdown

/promoted 4320

@sw-joelmut sw-joelmut closed this Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants