Skip to content

ci: pin action hashes and escape variables with minimum permission - #91

Merged
zimeg merged 2 commits into
mainfrom
ci-audit
May 20, 2025
Merged

zimeg merged 2 commits into
mainfrom
ci-audit

Conversation

@zimeg

@zimeg zimeg commented May 15, 2025

Copy link
Copy Markdown
Member

Summary

This PR uses the wonderful zizmor tool to audit our own workflows and pinact for pinned versioning 👾

While not so simple to bump ourselves, the kind @dependabot can help keep these hashes updated 🤖 ✨

Reviewers

A similar audit can be performed with the zizmor tool:

$ zizmor .
...
No findings to report. Good job! (2 suppressed)

Notes

Similar changes exist in slackapi/slack-github-action#441 but comments on unexpected changes follow!

Requirements

@zimeg zimeg self-assigned this May 15, 2025
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label May 15, 2025
@codecov

codecov Bot commented May 15, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (61c571a) to head (8108018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files           6        6           
  Lines         369      369           
=======================================
  Hits          349      349           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Leaving one comment on updated permissions of the publish workflow for the wonderful reviewers!

Next release of this action, let's keep an eye on this 👁️‍🗨️

Comment on lines +10 to +11
permissions:
contents: write

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These permissions are noted in JasonEtco/build-and-tag-action#45 and match a similar workflow that's found in slackapi/slack-github-action

@hello-ashleyintech hello-ashleyintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the PR is well written and documented for this change! Thank you 🙇

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for the minimum permission 💯

This might be a hot take but I don't think we need to pin the hashes, I think the readability of the raw version outweighs the benefits of pinning hashes and leaving comments for the actual version, I'm concerned about how dependabot handles updating these dependencies :dependabot:

Could you explain what are the security improvements gained by using the hash rather then referencing the version and share any documented cases of critical vulnerability in this area 🙏

It may also be worth considering what is at risk here, as far as I know these Github Actions don't have access to our package release keys, I don't think we should be building a "complex security vault" if we are leaving it empty

@zimeg
zimeg requested a review from WilliamBergamin May 19, 2025 22:37
@zimeg

zimeg commented May 19, 2025

Copy link
Copy Markdown
Member Author

@hello-ashleyintech @WilliamBergamin Once more, I appreciate the fast reviews so much 🙏 ✨

@WilliamBergamin Following the comment of slackapi/slack-github-action#441 I'm requesting another review before merge! Please let me know if other changes are requested but I shall continue onto other projects we maintain for the meantime.

@zimeg

zimeg commented May 20, 2025

Copy link
Copy Markdown
Member Author

@hello-ashleyintech @WilliamBergamin I appreciate the reviews too on this PR. I am going to merge this and similar PRs now 🫡

@zimeg
zimeg merged commit da74f86 into main May 20, 2025
@zimeg
zimeg deleted the ci-audit branch May 20, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants