Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

Add implementation for loading signing keys from Key Vault #533 - #660

Closed
berendhaan wants to merge 1 commit into
skoruba:devfrom
berendhaan:dev
Closed

Add implementation for loading signing keys from Key Vault #533#660
berendhaan wants to merge 1 commit into
skoruba:devfrom
berendhaan:dev

Conversation

@berendhaan

@berendhaan berendhaan commented Jul 24, 2020

Copy link
Copy Markdown

This feature can be enabled by setting TokenSigningConfiguration.UseAzureKeyVault to true and adding the following configuration options in the appsettings.json.

"AzureKeyVaultConfiguration": {
       "KeyVaultUri": "",
        "KeyName": ""
}

Some remarks:

  • There is no caching of the keys
  • Needs explanation how to configure Key Vault correctly
  • Not battle-tested, at the moment max 3 users and signing in a couple of times a week

@berendhaan berendhaan mentioned this pull request Jul 24, 2020
Open
@skoruba

skoruba commented Oct 28, 2020

Copy link
Copy Markdown
Owner

Hi @berendhaan - thank you for your PR, I've decided to load certificate from Azure KV on application startup currently - that is the reason why I am closing this PR. Thank you for your effort on this PR.

@skoruba skoruba closed this Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@berendhaan @skoruba