Skip to content

[claude] Close the fwdata project when media sync fails - #2875

Open
myieye wants to merge 1 commit into
developfrom
claude/fw-headless-close-fwdata-on-media-sync-failure
Open

myieye wants to merge 1 commit into
developfrom
claude/fw-headless-close-fwdata-on-media-sync-failure

Conversation

@myieye

@myieye myieye commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

DeferCloseAsync was registered after SyncMediaFiles, so a failure there left the loaded LcmCache in the 30-minute cache while the next job loaded another project beside it. Moving the registration one statement up only changes when the close happens on that failure path; the cache's eviction callback disposes the same way.

  • Not built locally (no .NET SDK in this session); it is a one-statement move inside the same method, so CI's build is the check.

Generated by Claude Code

DeferCloseAsync was registered after SyncMediaFiles, so a failure there left
the loaded LcmCache in the 30-minute cache while the next job loaded another
project next to it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AM78WDGRwYjhxtfmrFr3az
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 25cf72d4-a1ef-4f72-bf5e-a46b019c1e50
Commits

Reviewing files that changed from the base of the PR and between 5efc48f and d92f23f.

Files selected for processing: 1
  • backend/FwHeadless/Services/SyncHostedService.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 📦 Lexbox issues related to any server side code, fw-headless included label Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants