Repository navigation
Fix Static Analyse failure for InAppPurchaseStruct coverage rule - #209
Merged
Merged
Conversation
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Static Analyse
Fix Static Analyse failure for InAppPurchaseStruct coverage rule
Sep 11, 2026
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Static Analysejob started failing becauseInAppPurchaseStructwas marked@codeCoverageIgnorewhilefromArray()contains executable mapping logic. This aligns the struct with Shopware’s coverage rule and adds direct coverage for the behavior PHPStan flagged.Root cause
InAppPurchaseStruct::fromArray()performs status normalization and nested price model mapping, so the class should not be excluded from coverage.Code changes
@codeCoverageIgnorefromInAppPurchaseStruct.InAppPurchaseStruct::fromArray().Coverage added
InAppPurchaseStatus.INACTIVE.priceModelsdata is mapped into the expected collection/structs.