Repository navigation
ECTO-2706 - include installed extension versions in store context - #180
Merged
Merged
Conversation
Jannik (qysp)
approved these changes
Jun 29, 2026
Marvin Sibbing (mappinnn)
force-pushed
the
feature/ECTO-2706
branch
2 times, most recently
from
June 29, 2026 08:44
9c17520 to
c3faff6
Compare
Jannik (qysp)
approved these changes
Jun 29, 2026
| await this.installExtension(cartData); | ||
| } | ||
|
|
||
| const extensionVersion = await this.getOwnedExtensionVersion(cartData.positions[0].extension.name); |
Collaborator
There was a problem hiding this comment.
Doesn't this only work when the extension was actually installed?
Collaborator
Author
There was a problem hiding this comment.
Habs nochmal angepasst, wir versuchen nun die Version nur zu lesen, wenn nach dem Kauf auch wirklich eine Installation angestoßen wurde.
Jannik (qysp)
self-requested a review
June 29, 2026 11:02
Marvin Sibbing (mappinnn)
force-pushed
the
feature/ECTO-2706
branch
from
June 29, 2026 13:43
c3faff6 to
166b958
Compare
Jannik (qysp)
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.