Repository navigation
ECTO-2679 - Support deep linking to PDP by internal ID or technical name - #170
Merged
Merged
Conversation
Jannik (qysp)
force-pushed
the
feature/ECTO-2679
branch
from
June 15, 2026 15:36
baabcbc to
9af1d2b
Compare
Jannik (qysp)
requested review from
Florian Büscher (FloBWer) and
Kai Gossel (kaigossel)
and removed request for
Kai Gossel (kaigossel)
June 15, 2026 15:36
Jannik (qysp)
marked this pull request as ready for review
June 15, 2026 15:37
There was a problem hiding this comment.
Pull request overview
Adds support for deep-linking into the Extension Store product detail page (PDP) using either an internal ID or a technical name by passing an identifier via history.state and exposing it to the store iframe/channel handshake.
Changes:
- Extend the extension-store channel handshake context with an optional
navigateToExtensionidentifier derived fromwindow.history.state. - Adjust the
sw.extension.store.detailroute to redirect into the catch-all store route while forwarding the identifier viahistory.state. - Update the dashboard “statistics promotion” card to route to
sw.extension.store.detailusing the technical name (and adapt tests accordingly).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Resources/app/administration/src/module/sw-extension-store/service/extension-store-channel.service.ts | Adds navigateToExtension to the handshake payload based on history.state. |
| src/Resources/app/administration/src/module/sw-extension-store/index.js | Reworks store detail routing to redirect and forward an identifier via history.state. |
| src/Resources/app/administration/src/module/sw-dashboard/component/sw-dashboard-statistics-promotion-card/index.js | Switches navigation to the store detail route using the technical name directly. |
| src/Resources/app/administration/src/module/sw-dashboard/component/sw-dashboard-statistics-promotion-card/sw-dashboard-statistics-promotion-card.spec.js | Updates routing expectations and removes now-obsolete behavior tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jannik (qysp)
force-pushed
the
feature/ECTO-2679
branch
from
June 16, 2026 06:42
9af1d2b to
38b54e7
Compare
Kai Gossel (kaigossel)
approved these changes
Jun 17, 2026
Florian Büscher (FloBWer)
approved these changes
Jun 18, 2026
Jannik (qysp)
added a commit
that referenced
this pull request
Jun 19, 2026
Jannik (qysp)
added a commit
that referenced
this pull request
Jun 19, 2026
Jannik (qysp)
added a commit
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion with the iframe