Repository navigation
fix(audio): keep concurrent audio streams with the same type apart - #44
Open
code-new-bie wants to merge 1 commit into
Open
code-new-bie wants to merge 1 commit into
code-new-bie wants to merge 1 commit into
Conversation
CarPlay can run several audio streams of the same stream type at once: music, navigation prompts and Siri can all arrive as type 100, told apart only by their audioType. Streams, audio metadata, packet captures, renderers and microphone uplinks were keyed by the type alone, so a second stream replaced the first one's renderer and the first stream went silent or played through the wrong output. They are now keyed by (type, audioType) through a new AudioStreamId: a new stream only replaces one with the same audio type, and a TEARDOWN, which names only the stream type, releases every audio type variant of it. The web display media tap still receives the stream type, as before. CarPlayMediaEngineTest covers two concurrent type-100 streams and their teardown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CarPlay can run several audio streams of the same stream type at once: music,
navigation prompts and Siri can all arrive as type 100, told apart only by
their audioType. Streams, audio metadata, packet captures, renderers and
microphone uplinks were keyed by the type alone, so a second stream replaced
the first one's renderer and the first stream went silent or played through
the wrong output.
They are now keyed by (type, audioType) through a new AudioStreamId: a new
stream only replaces one with the same audio type, and a TEARDOWN, which names
only the stream type, releases every audio type variant of it. The web display
media tap still receives the stream type, as before.
CarPlayMediaEngineTest covers two concurrent type-100 streams and their
teardown.