Repository navigation
Use design-system dialog to confirm task deletion - #1351
Merged
selfcontained merged 1 commit intoOct 30, 2026
Merged
selfcontained merged 1 commit into
selfcontained merged 1 commit into
Conversation
selfcontained
deleted the
agt_eb6ab65be881/use-design-system-dialog-to-confirm-task
branch
October 30, 2026 03:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task deletion now opens the existing styled AlertDialog from both the task drawer and the task modal. The dialog identifies the task, explains permanent deletion, initially focuses Cancel, and requires explicit destructive confirmation. Pending submissions cannot duplicate or escape through global shortcuts; failures stay visible for retry or cancellation. Switching tasks discards an open confirmation and late responses cannot close the replacement task.
The existing deletion API and backend policy are unchanged. Column deletion and archival are outside this change.
Validation:
pnpm run check,pnpm run finalize:web, full isolatedpnpm run test:e2e, and 41 focused dialog/drawer/modal tests. Desktop and 390px mobile Playwright flows exercise Cancel/Escape/focus, nested modal behavior, shortcut isolation, pending/error/retry and real deletion of disposable tasks without native browser dialogs. Screenshots and retained isolated LAN preview are in the task acceptance handoff.Owner reviews: frontend-react-review and code-review completed. The frontend review's shortcut-isolation finding was fixed and verified; no unresolved findings.