Repository navigation
perf(blocking): send request bodies in 64 KiB chunks - #3125
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
patrick-immometrica
force-pushed
the
perf-blocking-upload-chunk
branch
from
October 24, 2026 23:29
c42fd1e to
32927fd
Compare
patrick-immometrica
marked this pull request as ready for review
October 24, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocking client sends a request body by reading it into an 8 KiB buffer and passing each chunk over a zero-capacity channel to the runtime thread. A large upload pays one thread handoff, one allocation and one zeroing per 8 KiB.
This raises the chunk size to 64 KiB, still capped by the body's length when that's known.
Uploading 256 MiB from Body::sized to a local server went from a median of about 1,170 ms (220 MiB/s) to 260 ms (980 MiB/s) over 7 runs.
The test posts a 200,000-byte body, sized and unsized, and checks that the server receives it byte-for-byte.