Repository navigation
fix(table): load the values list of columns under a grouped header - #125
Merged
Merged
Conversation
The table loaded `values` lookups for top-level columns only. A `values` column under a grouped header (`type: 'children'`) never got its list: its cells (and the export) showed the raw codes instead of the display text, whatever the kind of `items` (array, signal, function), and with `items` as a function the function was never called, so the column filter offered nothing. The configuration hydration now passes leaf columns (`leafColumns()`) to `loadValues`, still limited to the displayed columns. Spec, written first and seen failing (3 red): table.component .grouped-values.spec.ts — display text for array / function / signal items, the function called once, the column filter list filled. Docs: sd-table.md (grouped headers), CHANGELOG [Unreleased] Fixed › Table. Rolled out from v19 with npm run sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sd-tableloaded the lists ofvaluescolumns for top-level columns only. Avaluescolumn under a grouped header (type: 'children') never got its list:new) instead of the display text (Chờ xác nhận), whatever the kind ofitems(array, signal, function), and so did the export;itemsas a function, the function was never called, so the column filter offered nothing.The configuration hydration now passes leaf columns (
leafColumns()) toSdTableFormatService.loadValues, still limited to the displayed columns — a one-line change intable.component.ts.Found by the independent review of #124 (out of that PR's scope); same root cause as the grouped-header filter fix in #124.
API consistency
No public API change: no input, output, option, autoId or export added, renamed or removed.
leafColumns()is the internal helper already used by the filter pipeline. v19 → v20/v21/v22 throughnpm run sync;check:syncgreen.Verification
table.component.grouped-values.spec.ts(written first, 3 red before the fix): display text for array / function / signal items under a grouped header, the function called once, the column filter list filled.ng test sdcorejs-angular --code-coverage: 8672/8672 (Statements 87.49%, Branches 78.4%, Functions 86.5%, Lines 89.93%).npm run lint,npm run test:theme(53/53),npm run check:scss-hex(0),npm run check:sync,test:showcase-changelog.sd-table.md(grouped headers), CHANGELOG[Unreleased]› Fixed › Table.Independent review: not done for this one-line fix.
🤖 Generated with Claude Code