Repository navigation
problem with release notes link on front page #1
Description
The "release notes" link as in the screenshot below points to the "master" branch rather than the stable v0.19.x branch. At minimum, the "master" in the link is outdated and should be updated to "main" (although automatic redirect is currently working okay).
I noticed this because despite releasing 0.19.2 today, the link there still showed only v0.19.0 release notes. I should have just made the release note PRs to main and then backported them to v0.19.x so this could not occur. However, shouldn't the "stable" release notes link point to the file in the v0.19.x branch instead?
Activity
jni commentedon Feb 18, 2022
Yes I think they should.
jni commentedon Feb 18, 2022
It looks like this is the line that needs updating:
https://github.com/scikit-image/scikit-image-web/blob/6df11016dd2fd0bf0048ec5b995f561feebbff58/_templates/sidebar_versions.html#L37
stefanv commentedon Feb 18, 2022
I get the 0.19.2 release notes when I click on the frontpage link.
grlee77 commentedon Feb 18, 2022
That's because @jni merged scikit-image/scikit-image#6253 so that those notes are also on main
stefanv commentedon Feb 18, 2022
Perfect, thanks!
jni commentedon Feb 19, 2022
@stefanv That doesn't address the bigger problem — that stable should point to stable rather than main?
stefanv commentedon Feb 19, 2022
Seems like a good check to ensure that we remember committing those notes in the right place, though?
jni commentedon Apr 6, 2022
I feel like a broken public website is not the best indicator for this sort of thing. Something like a GitHub Action check would be better!