Skip to content

Disable i128 and u128 on emscripten (fixes #669) - #671

Merged
dhardy merged 2 commits into
rust-random:masterfrom
svenstaro:fix-emscripten-target
Dec 30, 2018
Merged

dhardy merged 2 commits into
rust-random:masterfrom
svenstaro:fix-emscripten-target

Conversation

@svenstaro

Copy link
Copy Markdown
Contributor

This was also reported as #669, koute/cargo-web#152 and emscripten-core/emscripten-fastcomp#169.

Basically emscripten can't properly deal with i128 and u128. This should be fixed in emscripten upstream but it's unlikely to happen. This is the best we can do. This also changes the .travis-ci.yml so that this problem doesn't re-occur without getting caught.

@svenstaro

Copy link
Copy Markdown
Contributor Author

The failure seems unrelated to my changes.

@svenstaro

svenstaro commented Dec 25, 2018 •

Copy link
Copy Markdown
Contributor Author

You can get this building by clearing the cache.

@dhardy

dhardy commented Dec 29, 2018

Copy link
Copy Markdown
Member

I tried clearing the cache (twice now I think). No luck there.

@svenstaro

Copy link
Copy Markdown
Contributor Author

I fixed it @dhardy

@dhardy
dhardy merged commit 158c3e9 into rust-random:master Dec 30, 2018
@svenstaro

Copy link
Copy Markdown
Contributor Author

Could you make a release with this included?

@svenstaro
svenstaro deleted the fix-emscripten-target branch January 2, 2019 03:57
@dhardy

dhardy commented Jan 6, 2019 •

Copy link
Copy Markdown
Member

@svenstaro why are my builds now all failing with this?

$ EMCC_CFLAGS="-s ERROR_ON_UNDEFINED_SYMBOLS=0" cargo web test --target wasm32-unknown-emscripten --no-run
Downloading emscripten-1.38.19-1-x86_64-unknown-linux-gnu.tgz...
2.73 MB / 201.71 MB [>----------------------------

@svenstaro

Copy link
Copy Markdown
Contributor Author

@dhardy taking a look.

@svenstaro

Copy link
Copy Markdown
Contributor Author

That's really weird though, isn't it? Pull requests work, your master branch builds do not.

@svenstaro

Copy link
Copy Markdown
Contributor Author

The only thing that's different at this step between PRs and master is secrets, env vars, and the cache key as far as I know. I can't see your secrets and env vars but can you check those and see whether there's anything weird? Also, could you try clearing cache?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants