Repository navigation
Disable i128 and u128 on emscripten (fixes #669) - #671
Merged
Merged
Conversation
Contributor
Author
|
The failure seems unrelated to my changes. |
Contributor
Author
|
You can get this building by clearing the cache. |
Member
|
I tried clearing the cache (twice now I think). No luck there. |
Contributor
Author
|
I fixed it @dhardy |
Contributor
Author
|
Could you make a release with this included? |
Member
|
@svenstaro why are my builds now all failing with this? |
Contributor
Author
|
@dhardy taking a look. |
Contributor
Author
|
That's really weird though, isn't it? Pull requests work, your master branch builds do not. |
Contributor
Author
|
The only thing that's different at this step between PRs and master is secrets, env vars, and the cache key as far as I know. I can't see your secrets and env vars but can you check those and see whether there's anything weird? Also, could you try clearing cache? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was also reported as #669, koute/cargo-web#152 and emscripten-core/emscripten-fastcomp#169.
Basically emscripten can't properly deal with
i128andu128. This should be fixed in emscripten upstream but it's unlikely to happen. This is the best we can do. This also changes the.travis-ci.ymlso that this problem doesn't re-occur without getting caught.