Skip to content

Adds support for deleting GitHub Pages settings - #2550

Merged
marcoieni merged 3 commits into
rust-lang:mainfrom
cuba0001:githug-pages-delete
Jul 3, 2026
Merged

marcoieni merged 3 commits into
rust-lang:mainfrom
cuba0001:githug-pages-delete

Conversation

@cuba0001

@cuba0001 cuba0001 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Related to #2518

Shouldn't be merged until all existing Github Pages Settings imported into repos/*.toml, otherwise sync may delete Pages settings that are still only configured on GitHub.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

@marcoieni

Copy link
Copy Markdown
Member

I asked AI to configure the github pages based on the dry run output in #2551 (comment).
Now I pushed the changes, let's see if the dry run output is empty.

Comment thread src/sync/github/mod.rs Resolved
@marcoieni

Copy link
Copy Markdown
Member

The dry run is clean 🥳
image

Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Jul 3, 2026
@marcoieni
marcoieni added this pull request to the merge queue Jul 3, 2026
Merged via the queue into rust-lang:main with commit 9a1b2b6 Jul 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants