Rustfmt drops 'default' from 'default fn …' using specialization #945

Activity

1. marcusklaas

   added

   good first issueIssues up for grabs, also good candidates for new rustfmt contributorsIssues up for grabs, also good candidates for new rustfmt contributors

   C-bugCategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICECategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICE

   and removed

   C-bugCategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICECategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICE

   on Apr 16, 2016
2. zitsen commented on May 19, 2016

   

   zitsen

   on May 19, 2016

   More actions

   I'm waiting for this impl.
3. nrc

   added

   P-highHigh priorityHigh priority

   on May 31, 2016
4. nrc

   added this to the 1.0This milestone has been deleted milestone on May 31, 2016
5. julienXX commented on May 31, 2016

   

   julienXX

   on May 31, 2016

   Contributor

   More actions

   I'd like to try to fix this one if no one is already working on it.
6. regexident commented on May 31, 2016

   

   regexident

   on May 31, 2016

   Contributor

   More actions

   line hint (spoiler alert! 😉 )
7. lqd commented on May 31, 2016

   

   lqd

   on May 31, 2016

   Member

   More actions

   To me it looked like the syntex visitor didn't pass the defaultness ? (but I'm unfamiliar with both syntex and rustfmt so I could be very mistaken)
8. regexident commented on May 31, 2016

   

   regexident

   on May 31, 2016

   Contributor

   More actions

   To me it looked like the syntex visitor didn't pass the defaultness ? (but I'm unfamiliar with both syntex and rustfmt so I could be very mistaken)

   That's true in fact, afaikt:

   syntax::ast::TraitItemKind::Method(MethodSig, Option<P<Block>>)

   pub struct MethodSig {
       pub unsafety: Unsafety,
       pub constness: Constness,
       pub abi: Abi,
       pub decl: P<FnDecl>,
       pub generics: Generics,
   }
9. lqd commented on May 31, 2016

   

   lqd

   on May 31, 2016

   Member

   More actions

   @julienXX salut Julien ;)

   I think I'm close-ish to making a PR as I was talking about this issue with @nrc on IRC earlier today, would you mind if I took a crack at it ?
10. julienXX commented on May 31, 2016

    

    julienXX

    on May 31, 2016

    Contributor

    More actions

    @lqd no problem 👍
11. marcusklaas

    closed this as completedin #1025on May 31, 2016
12. marcusklaas

    added a commit that references this issue on May 31, 2016

    Add support for the `default` keyword (#1025)

    ...

    This issue will close once commit b626373 is merged into the 'main' branch.

    b626373
13. nrc commented on Jun 1, 2016

    

    nrc

    on Jun 1, 2016

    Member

    More actions

    @julienXX if you want to work on a rustfmt, there are a bunch of good issues - https://github.com/rust-lang-nursery/rustfmt/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy - I'm happy to mentor any of them - either ping me on irc or comment on the bug.
14. julienXX commented on Jun 1, 2016

    

    julienXX

    on Jun 1, 2016

    Contributor

    More actions

    @nrc will do, thanks :)
15. jaredthecoder commented on Jun 5, 2016

    

    jaredthecoder

    on Jun 5, 2016

    More actions

    @nrc I'd love to jump on some of those. I'll find you on IRC if I have any issues.