Comments with lots of /s should not have spaces inserted #652

Activity

1. nrc

   added

   C-bugCategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICECategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICE

   A-commentsArea: commentsArea: comments

   on Nov 23, 2015
2. nrc

   added this to the 1.0This milestone has been deleted milestone on Apr 6, 2016
3. marcusklaas

   self-assigned this

   on Apr 18, 2016
4. marcusklaas commented on Apr 18, 2016

   

   marcusklaas

   on Apr 18, 2016

   Contributor

   More actions

   My lord, I forgot how much of a mess the comment code is 😱
5. crumblingstatue commented on May 13, 2016

   

   crumblingstatue

   on May 13, 2016

   Last edited by crumblingstatue

   Contributor

   More actions

   Might not be the same issue, but we encountered this in rust-sfml.

   The normal commented out code gets changed to doc comments.

    /// Shapes implementations using reference counting to manage shared resources
   -// pub mod rc {
   -//     pub use graphics::circle_shape::rc::CircleShape;
   -//     pub use graphics::rectangle_shape::rc::RectangleShape;
   -//     pub use graphics::convex_shape::rc::{ConvexShape, ConvexShapePoints};
   -//     pub use graphics::shape::rc::Shape;
   -//     pub use graphics::shader::rc::Shader;
   -//     pub use graphics::text::rc::Text;
   -//     pub use graphics::sprite::rc::Sprite;
   -//     pub use graphics::render_states::rc::RenderStates;
   -// }
   +/// pub mod rc {
   +///     pub use graphics::circle_shape::rc::CircleShape;
   +///     pub use graphics::rectangle_shape::rc::RectangleShape;
   +///     pub use graphics::convex_shape::rc::{ConvexShape, ConvexShapePoints};
   +///     pub use graphics::shape::rc::Shape;
   +///     pub use graphics::shader::rc::Shader;
   +///     pub use graphics::text::rc::Text;
   +///     pub use graphics::sprite::rc::Sprite;
   +///     pub use graphics::render_states::rc::RenderStates;
   +/// }

   EDIT: This issue does not seem to appear using the rustfmt master branch.
6. srinivasreddy commented on Jul 17, 2016

   

   srinivasreddy

   on Jul 17, 2016

   Contributor

   More actions

   As said in #1094 I am taking this. Thanks @nrc
7. srinivasreddy

   unassigned

   marcusklaas

   on Jul 17, 2016
8. nrc

   added

   only-with-optionRequires a non-default option value to reproduceRequires a non-default option value to reproduce

   and removed

   only-with-optionRequires a non-default option value to reproduceRequires a non-default option value to reproduce

   on Jan 16, 2017
9. nrc

   closed this as completedin 0218a41on Jan 16, 2017
10. topecongiro commented on May 28, 2017

    

    topecongiro

    on May 28, 2017

    Contributor

    More actions

    This issue still get reproduced when normalize_comments = true.
11. topecongiro

    reopened this on May 28, 2017
12. topecongiro

    added

    only-with-optionRequires a non-default option value to reproduceRequires a non-default option value to reproduce

    on May 28, 2017
13. nrc

    closed this as completedin #1607on May 30, 2017