Repository navigation
Eats r#try! -> try! in macros #4138
Description
I've not had time to do a lot of debugging here, but when doing an update of rustfmt in Rust (see the linked PR) we encountered a bug that rustfmt will apparently replace r#try! with try!, which is not an acceptable change to make on 2018 edition code. I've not attempted a reproduction outside of that one instance -- if this doesn't easily reproduce I'm not too worried by it.
We've fixed this in rust-lang/rust I believe with a manual #[rustfmt::skip] annotation.
Originally posted by @jonas-schievink in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQxMzM3MzI4OA==/comments/review_comment
Activity
topecongiro commentedon Apr 23, 2020
Thank you for the report, though the link seems to be broken.
calebcartwright commentedon Apr 23, 2020
GitHub is being weird with the links, but I believe this is it: rust-lang/rust#71439 (comment)
topecongiro commentedon Apr 23, 2020
@calebcartwright Thanks!
@Mark-Simulacrum I am not sure how the rustc repository uses rustfmt, but it seems that rustfmt is using edition 2015 to format the file.
Mark-Simulacrum commentedon Apr 23, 2020
Ah, I think it might've actually been a bug with my editor configuration. Sorry for the noise!