You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My recommendation/personal preference would be to let this crate remain a pure mirror of rustdoc-json-types in rust-lang/rust without any extra stuff.
Just in case this thought of yours was initiated by Enselic/public-api#27: I was simply silly enough to assume 0.7.0 had not been released yet when I wrote it. I didn't think you would be that fast. Super super silly. Sorry :)
The rustdoc JSON is still too much of a moving target for it to make sense to be "nice" about it IMHO. At least for a low-level crate like this one. On higher level crates it might very well make sense to be a bit nicer. In any case, I think it is better to put effort into making progress on rustdoc JSON itself rather than making this crate bigger.
I don't think it should be in this crate as there is a bit of complexity involved, in cargo-semver-checks we might want to move to simd_json for it's tape API, which allows us to parse the JSON once, extract the version, then use the correct rustdoc-types::Crate to deserialize that version (without parsing the JSON again).
simd_json is not 1.0 yet so I don't think rustdoc-types should depend on it. Maybe under a feature gate?
Activity
Enselic commentedon Feb 24, 2022
My recommendation/personal preference would be to let this crate remain a pure mirror of rustdoc-json-types in rust-lang/rust without any extra stuff.
Just in case this thought of yours was initiated by Enselic/public-api#27: I was simply silly enough to assume 0.7.0 had not been released yet when I wrote it. I didn't think you would be that fast. Super super silly. Sorry :)
The rustdoc JSON is still too much of a moving target for it to make sense to be "nice" about it IMHO. At least for a low-level crate like this one. On higher level crates it might very well make sense to be a bit nicer. In any case, I think it is better to put effort into making progress on rustdoc JSON itself rather than making this crate bigger.
aDotInTheVoid commentedon Mar 6, 2022
I think if/when I do this it should be a different crate
Boscop commentedon Oct 3, 2024
@aDotInTheVoid Thanks for the loader code :)
+1 I think it would make sense to have it in this crate.
jalil-salame commentedon Oct 20, 2024
I don't think it should be in this crate as there is a bit of complexity involved, in
cargo-semver-checkswe might want to move tosimd_jsonfor it's tape API, which allows us to parse the JSON once, extract the version, then use the correctrustdoc-types::Crateto deserialize that version (without parsing the JSON again).simd_jsonis not 1.0 yet so I don't thinkrustdoc-typesshould depend on it. Maybe under a feature gate?