Skip to content

Find crate by name should return a vector #40

Closed

Description

@celinval

Since a crate name can match more than one crate, I was wondering if we should return a vector instead of an Option<Crate>.

See an example on rustc test tests/codegen/nounwind.rs.

Activity

  1. added 2 commits that reference this issue on Oct 9, 2023
  2. added a commit that references this issue on Oct 9, 2023
  3. added a commit that references this issue on Oct 10, 2023
  4. spastorino commented on Oct 11, 2023

    @spastorino
    Member

    I think this can be closed after rust-lang/rust#116543 from @ouz-a, right?.

  5. ouz-a commented on Oct 11, 2023

    @ouz-a

    Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions